Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73302] Restore margins around setup wizard alert messages #9658

Merged

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Aug 25, 2024

[JENKINS-73302] Restore margins around setup wizard alert messages

JENKINS-73302 reports that when a user of the setup wizard skips the creation of a user and skips the assignment of the Jenkins URL, the two alert messages no longer have a margin between them.

This adds a top margin to each of the messages so that when two messages are displayed, there will be a margin between them. Follows the same pattern of margin definition that is used elsewhere in Jenkins core.

Testing done

Checked the visual display with 2 messages and with each message alone.

Confirmed that margins were already included in the "Manage Jenkins" page when the old data admin monitor and the deprecated plugins admin monitor are both displayed. This change is not needed for the "Manage Jenkins" page, only for the setup wizard.

Before 2.459

two-warnings-before

After 2.459 and before the change

two-warnings-after-2 459

After the change

two-warnings-on-setup-wizard

Single warning alert (user creation skipped)

admin-user-skipped-setup

Single warning alert (Jenkins URL skipped)

Jenkins-url-skipped

Proposed changelog entries

  • Restore margins around setup wizard alert messages (regression in 2.459).

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mawinter69

Before the changes are marked as ready-for-merge:

Maintainer checklist

https://issues.jenkins.io/browse/JENKINS-73302 reports that when a
user of the setup wizard skips the creation of a user and skips the
assignment of the Jenkins URL, the two alert messages no longer have a
margin between them.

This adds a top margin to each of the messages so that when two messages
are displayed, there will be a margin between them.

Testing done:

Checked the visual display with 2 messages and with each message alone.
@MarkEWaite MarkEWaite added regression-fix Pull request that fixes a regression in one of the previous Jenkins releases web-ui The PR includes WebUI changes which may need special expertise bug For changelog: Minor bug. Will be listed after features labels Aug 25, 2024
@NotMyFault NotMyFault requested a review from a team August 25, 2024 18:48
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 25, 2024
@timja timja merged commit a6d093d into jenkinsci:master Aug 26, 2024
15 checks passed
@MarkEWaite MarkEWaite deleted the restore-margin-around-setup-wizard-warnings branch October 1, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants