[JENKINS-73302] Restore margins around setup wizard alert messages #9658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[JENKINS-73302] Restore margins around setup wizard alert messages
JENKINS-73302 reports that when a user of the setup wizard skips the creation of a user and skips the assignment of the Jenkins URL, the two alert messages no longer have a margin between them.
This adds a top margin to each of the messages so that when two messages are displayed, there will be a margin between them. Follows the same pattern of margin definition that is used elsewhere in Jenkins core.
Testing done
Checked the visual display with 2 messages and with each message alone.
Confirmed that margins were already included in the "Manage Jenkins" page when the old data admin monitor and the deprecated plugins admin monitor are both displayed. This change is not needed for the "Manage Jenkins" page, only for the setup wizard.
Before 2.459
After 2.459 and before the change
After the change
Single warning alert (user creation skipped)
Single warning alert (Jenkins URL skipped)
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mawinter69
Before the changes are marked as
ready-for-merge
:Maintainer checklist