Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73330] Fix dropdowns and tooltips on HDR displays #9654

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Aug 24, 2024

See JENKINS-73330.

Safari on macOS behaves a little differently to every other browser in that it turns on HDR when using the brightness(...) filter in CSS. This causes dropdowns, tooltips and dialogs to appear over exposed (and literally brighter) when working on a HDR display. It's pretty painful.

This PR fixes that, by removing the brightness() filter, and instead just setting the background on those elements to a semi translucent colour.

See #9649 for a fix to dialogs.

Testing done

  • Dropdowns and tooltips appear as expected, similar to how they did before, just not overblown

Proposed changelog entries

  • Fix dropdown and tooltip brightness on HDR displays.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

@janfaracik
Copy link
Contributor Author

/label web-ui

@comment-ops-bot comment-ops-bot bot added the web-ui The PR includes WebUI changes which may need special expertise label Aug 24, 2024
@NotMyFault NotMyFault added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Aug 25, 2024
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@NotMyFault NotMyFault requested a review from a team August 25, 2024 08:50
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 25, 2024
@timja timja merged commit a304977 into jenkinsci:master Aug 26, 2024
15 checks passed
@timja timja deleted the JENKINS-73330 branch August 26, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants