-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-73669] don't change unrelated checkboxes in rowSelectionCont… #9648
Conversation
…roller when a row in table contains more than 1 checkbox the rowSelectionController shouldn't change all checkboxes but only the one in the same column
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this isn’t used elsewhere? Another option would be to by default do all but allow narrowing it?
Approved anyway
I intend to use it, see link above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no security problem here.
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
when a row in table contains more than 1 checkbox the rowSelectionController shouldn't change all checkboxes but only the ones that match a given class.
See JENKINS-73669.
Testing done
Tested in context of jenkinsci/agent-maintenance-plugin#213
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist