[JENKINS-73592] refresh buildhistory widget when tab was hidden before

[mawinter69]

The current implementation of the load method exits early when the document is hidden to avoid unnecessary calls to the backend. But this avoids that the refreshTimeout is properly (re-)created.
This leads to 2 effects:

• when opening a job page in a new tab (ctrl+click) from a list view and then switching to the tab that the history widget is empty.
• after switching to another tab and then coming back to the job tab, the history no longer refreshes itself (See the Jira for reproduction steps)

See JENKINS-73592.

Testing done

Manual verified with the mentioned steps above that history widget is properly updated.

Proposed changelog entries

• refresh buildhistory widget when tab was hidden before

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[daniel-beck]

What the relevance of this condition?

It seems that the second problem (switching tabs) would still remain if I page through the build history first?

Is this just making this change consistent with a pre-existing bug? In testing it seems I'm not getting AJAX refreshes on page 2 of the widget.

[mawinter69]

Indeed when you're not on the first page of the build history and there is a running build, this will never get updated (independent of this change).
But that behaviour can also be seen on 2.462.x and earlier. So this is a long standing bug/limitation.

[mawinter69]

replaced by #9624