-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for remoting releases before 2024-08 #9569
Draft
daniel-beck
wants to merge
4
commits into
jenkinsci:master
Choose a base branch
from
daniel-beck:drop-pre-2024-08-remoting-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Drop support for remoting releases before 2024-08 #9569
daniel-beck
wants to merge
4
commits into
jenkinsci:master
from
daniel-beck:drop-pre-2024-08-remoting-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
github-actions
bot
added
the
unresolved-merge-conflict
There is a merge conflict with the target branch.
label
Aug 7, 2024
Please take a moment and address the merge conflicts of your pull request. Thanks! |
github-actions
bot
removed
the
unresolved-merge-conflict
There is a merge conflict with the target branch.
label
Aug 14, 2024
github-actions
bot
added
the
unresolved-merge-conflict
There is a merge conflict with the target branch.
label
Aug 25, 2024
Please take a moment and address the merge conflicts of your pull request. Thanks! |
github-actions
bot
removed
the
unresolved-merge-conflict
There is a merge conflict with the target branch.
label
Aug 26, 2024
github-actions
bot
added
the
unresolved-merge-conflict
There is a merge conflict with the target branch.
label
Sep 16, 2024
Please take a moment and address the merge conflicts of your pull request. Thanks! |
github-actions
bot
added
unresolved-merge-conflict
There is a merge conflict with the target branch.
and removed
unresolved-merge-conflict
There is a merge conflict with the target branch.
labels
Sep 16, 2024
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for SECURITY-3430 retains compatibility with older remoting releases to have a smoother upgrade experience. This PR drops that support. It's probably going to be a while before we want to merge this, but I thought it would be useful to have this prepared.
Testing done
Autotests
Proposed changelog entries
agent.jar
) releases from before August 2024.Proposed upgrade guidelines
(Copied from #9440 for consistency)
Increase the minimum required Remoting version to 3256.3258.v858f3c9a_f69d (released on August 7, 2024). When an agent with a Remoting version older than 3256.3258.v858f3c9a_f69d connects to the Jenkins controller, the agent connection is rejected. Ensure that all agents are running a recent version of Remoting prior to upgrading. Agents with unsupported Remoting versions can be allowed to connect to the controller by setting the
hudson.slaves.SlaveComputer.allowUnsupportedRemotingVersions
system property to true.Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist