Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73495] Clarify the plugin incompatibility message #9502

Merged

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Jul 29, 2024

[JENKINS-73495] Clarify the plugin incompatibility message

The issue submitter suggested that the plugin incompatibility message would be clearer if it specifically referred to the installed version of the plugin. That seems like an easy change to make and if it helps a few users, that is great.

See JENKINS-73495.

No automated tests because we generally do not test changes in messages.

Testing done

None. Rely on standard behavior of changes in message property files.

Proposed changelog entries

  • Clarify that the plugin incompatibility message applies to the current plugin.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

The issue submitter suggested that the plugin incompatibility message
would be clearer if it specifically referred to the installed version
of the plugin.  That seems like an easy change to make and if it helps
a few users, that is great.
@MarkEWaite MarkEWaite added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jul 29, 2024
@NotMyFault NotMyFault requested a review from a team July 31, 2024 15:12
@MarkEWaite
Copy link
Contributor Author

This PR is now ready for merge. We will merge it after the upcoming security release of Jenkins core if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 1, 2024
@MarkEWaite MarkEWaite merged commit 5acf535 into jenkinsci:master Aug 9, 2024
15 checks passed
@MarkEWaite MarkEWaite deleted the improve-plugin-compatibility-message branch October 5, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants