Allow administrative monitors to be displayed for users with Overall/MANAGE permission

[Vlatombe]

This allows users with Overall/MANAGE permission but not Overall/SYSTEM_READ to display administrative monitors if the administrative monitor has been implemented to allow it.

Testing done

Verified with a custom administrative monitor allowing Overall/MANAGE that it can be displayed in the corresponding UI area by a user with this permission.

Proposed changelog entries

• Allow some administrative monitors to be displayed for users with Overall/MANAGE permission

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[Vlatombe]

Hesitating to deprecate this method, but it still matches simple use cases so went for a javadoc instead.

[jglick]

Note that these methods are very similar to AccessControlled, but creating a custom ACL seems more laborious than implementing them as written.

[jglick]

What about AdministrativeMonitorsConfiguration and

jenkins/core/src/main/java/hudson/model/AdministrativeMonitor.java

Lines 178 to 179 in dc36857

	public void doDisable(StaplerRequest req, StaplerResponse rsp) throws IOException {
	Jenkins.get().checkPermission(Jenkins.ADMINISTER);

? With this change, IIUC, users with only MANAGE could see monitors and agree to fix the issue the monitor warns about, but they could not dismiss monitors they found irrelevant.

[jglick]

The Javadoc is misleading as it implies that you could grant permission to see admin monitors based on some other criteria. But in fact due to hasPermissionToDisplay these are really the only permissions you can check.