Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usages of YUI framework by simple JS/CSS #9395

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Jun 15, 2024

This replaces a few usages of YUI in core:

  • session storage for sortable tables (no need for compatibility layer provided by YUI)
  • repeateble form elements use standard CSS transition instead of YUI animations
  • avoid JS function makeButton and CSS selectors that trigger it (submit-button, yui-button)

This should mostly not cause changes in the UI except for a few button styles

Screenshots

Rekey dialog before:

rekey-before

After:

rekey-after

Expandable console note (after)

console-light console-dark

Slow trigger monitor (after)

monitor-dark

Testing done

  • Manually tested the buttons in screenshot (had to hack the Java code to create custom Expandable Note and trigger the monitors)
  • Manually tested adding steps to freestyle build and columns to a view to check the animations
  • Manually checked that table sorting is preserved on refresh in dashboard

There are no new tests as there is no new functionality here.

Proposed changelog entries

  • Remove some usages of YUI framework in the user interface.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@zbynek zbynek force-pushed the noyui branch 3 times, most recently from fe6b6e5 to dd798f7 Compare June 16, 2024 10:55
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timja timja requested a review from a team June 16, 2024 18:45
@timja timja added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jun 16, 2024
@timja timja requested a review from a team June 16, 2024 18:45
@timja timja added the needs-security-review Awaiting review by a security team member label Jun 16, 2024
@Kevin-CB Kevin-CB added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Jun 17, 2024
@timja
Copy link
Member

timja commented Jun 17, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 17, 2024
@timja timja merged commit d041c43 into jenkinsci:master Jun 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted security-approved @jenkinsci/core-security-review reviewed this PR for security issues web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants