Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72577] Revert "Increase MavenTest#sensitiveParameters() timeout to 500s" #9374

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jun 11, 2024

See JENKINS-72577.

Reverts #8840 which was a workaround for slow tests in the ci.jenkins.io's agents infrastructure as described in jenkins-infra/helpdesk#3890.

In the past 4 months, a lot of changes had been applied to the underlying infrastructure such as:

  • JDK21 upgrade to 21.0.3+9
  • Underlying Linux machines upgraded to powerful ones
  • Underlying network fixed
  • Agents workload fully migrated to an unified Azure cloud
  • etc.

Fixes jenkins-infra/helpdesk#3890

Testing done

I can see that the last "main" branch test (see https://ci.jenkins.io/job/Core/job/jenkins/job/master/6227/testReport/hudson.tasks/MavenTest/) is around ~6s on Linux (on ALL JDKs) and ~13s on Windows (JDK17):

Capture d’écran 2024-06-11 à 10 55 43

Proposed changelog entries

Proposed upgrade guidelines

N/A

Desired reviewers

@Not-NotMyFault @basil

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the performance improvements on the underlying infrastructure that have allowed this temporary workaround to be reverted.

@timja timja added the skip-changelog Should not be shown in the changelog label Jun 11, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I removed the timeout which was added for the same issue it was just increased once


/label ready-for-merge


This PR is now ready for merge, after the build has passed, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 11, 2024
@timja timja merged commit d4e970f into jenkinsci:master Jun 11, 2024
17 checks passed
@dduportal dduportal deleted the revert-8840-increase-mvn-param-test branch June 11, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible change to ci.jenkins.io's linux agents causes core test failure
3 participants