Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73246] Fix text shown in unexpected locale #9370

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

BobDu
Copy link
Member

@BobDu BobDu commented Jun 10, 2024

See JENKINS-73246.

Ref: #8912 (comment)

Special treatment if language is en

Testing done

run

mvn clean verify

Interactive test before this change shows Italian help text for "Manage Jenkins" -> "System" -> "Quiet period" when I am running in English language. After this change the help text for "Manage Jenkins" -> "System" -> "Quiet period" is correctly displayed as English.

Proposed changelog entries

  • Show help text in the correct locale even if user has an alternate language option defined in their browser (regression in 2.444).

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

@NotMyFault NotMyFault added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Jun 10, 2024
@timja
Copy link
Member

timja commented Jun 10, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 10, 2024
@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label Jun 11, 2024
@MarkEWaite
Copy link
Contributor

I'm accelerating the merge of this one because it would be nice to include in 2.452.3 as a backport.

@MarkEWaite MarkEWaite merged commit 0ad6657 into jenkinsci:master Jun 11, 2024
16 checks passed
@BobDu BobDu deleted the fix-73246 branch June 12, 2024 04:34
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Jun 24, 2024
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants