Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72854] fix the enum jelly to take readOnlyMode into account #9336

Merged

Conversation

Pldi23
Copy link
Contributor

@Pldi23 Pldi23 commented May 31, 2024

JENKINS-72854 fix the enum jelly to take readOnlyMode into account

During fixing UX issue in kubernetes-plugin it was found that enum.jelly do not work with readOnlyMode, see PR jenkinsci/kubernetes-plugin#1566 for the reference.

Testing done

Manually tested this PR + jenkinsci/kubernetes-plugin#1566. With that change readOnlyMode works.
Screenshot 2024-05-31 at 09 20 34

Proposed changelog entries

  • Honor read-only mode when displaying enumerations on pages.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@Vlatombe
Copy link
Member

Reminder to fill the changelog entry

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 3, 2024
@timja timja merged commit 8088382 into jenkinsci:master Jun 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants