Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn Java 11 users of 18 Jun 2024 end of life in weekly #9314

Merged
merged 1 commit into from
May 27, 2024
Merged

Warn Java 11 users of 18 Jun 2024 end of life in weekly #9314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion core/src/main/java/jenkins/monitor/JavaVersionRecommendationAdminMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,16 @@

static {
NavigableMap<Integer, LocalDate> supportedVersions = new TreeMap<>();
supportedVersions.put(11, LocalDate.of(2024, 9, 30)); // Temurin: 2024-10-31
// Adjust Java 11 end of life date for weekly and LTS
if (Jenkins.VERSION.split("[.]").length > 2) {

Check warning on line 82 in core/src/main/java/jenkins/monitor/JavaVersionRecommendationAdminMonitor.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 82 is only partially covered, one branch is missing
// LTS will require Java 17 or newer beginning 30 Oct 2024
// https://groups.google.com/g/jenkinsci-dev/c/gsXAqOQQEPc/m/VT9IBYdmAQAJ
supportedVersions.put(11, LocalDate.of(2024, 10, 30)); // Temurin: 2024-10-31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given some remaining uncertainty around LTS dates it seems unnecessary to commit to another month.

} else {
// Weekly will require Java 17 or newer beginning 18 Jun 2024
// https://groups.google.com/g/jenkinsci-dev/c/gsXAqOQQEPc/m/4fn4Un1iAwAJ
supportedVersions.put(11, LocalDate.of(2024, 6, 18)); // Temurin: 2024-10-31

Check warning on line 89 in core/src/main/java/jenkins/monitor/JavaVersionRecommendationAdminMonitor.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line 

Line 89 is not covered by tests
}
supportedVersions.put(17, LocalDate.of(2026, 3, 31)); // Temurin: 2027-10-31
supportedVersions.put(21, LocalDate.of(2027, 9, 30)); // Temurin: 2029-09-30
SUPPORTED_JAVA_VERSIONS = Collections.unmodifiableNavigableMap(supportedVersions);
Expand Down
Loading