Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usages of JZlib with native Java Platform functionality #9312

Merged
merged 3 commits into from
May 27, 2024

Conversation

basil
Copy link
Member

@basil basil commented May 25, 2024

I think we're leaving some performance on the table by using JZlib rather than the native Java Platform gzip functionality. In my stress test in #9311 I saw a 30% improvement with these changes. Whatever debug probe Kohsuke added in commit 694ed60 seems to have long outlived its usefulness 16 years later.

Testing done

CI build

Proposed changelog entries

  • Improve the performance of file compression and decompression.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@basil basil added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label May 25, 2024
@MarkEWaite
Copy link
Contributor

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 25, 2024
@MarkEWaite MarkEWaite merged commit f6e9283 into jenkinsci:master May 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants