Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting for LTS 2.452.2 #9305

Conversation

krisstern
Copy link
Member

@krisstern krisstern commented May 24, 2024

Latest core version: jenkins-2.459

Postponed
---------

JENKINS-73168           Minor                   2.459
        "No changes" does not appear (regression in 2.453)
        regression
        https://issues.jenkins.io/browse/JENKINS-73168

Fixed
-----

JENKINS-73114           Minor                   2.459
        Jenkins css classes for alerts collide with bootstrap5
        https://issues.jenkins.io/browse/JENKINS-73114

JENKINS-73093           Minor                   2.457
        Update bundled script-security to 1336.vf33a_a_9863911
        https://issues.jenkins.io/browse/JENKINS-73093

JENKINS-72622           Major                   2.459
        EC2 plugin cannot add a new cloud
        https://issues.jenkins.io/browse/JENKINS-72622

JENKINS-64553           Major                   Tue, 28 May 2024 12:59:30 +0000
        ItemListener.onUpdated() isn't fired when modifying Item
        https://issues.jenkins.io/browse/JENKINS-64553

Submitter checklist

Before the changes are marked as ready-for-merge:

Maintainer checklist

daniel-beck and others added 3 commits May 25, 2024 01:57
…nsci#9224)

Update script-security to 1336.vf33a_a_9863911

Co-authored-by: Daniel Beck <[email protected]>
(cherry picked from commit b89863c)
…insci#9254)

* [JENKINS-73114] avoid conflict of css classes with bootstrap

jenkins and bootstrap both have definitions for alert and alert-warning,
alert-info, alert-danger. Bootstrap css definitions are included when
e.g. the warning-ng plugin is installed and a job is configured to scan
for warnings. The css classes from bootstrap are then chosen instead of
the ones for Jenkins for things like the admin monitors.
To make things umambiguous, add additional classes prefixed with
`jenkins-` and make use of them in code. Keep the old definitions for
backward compatibility with plugins.
Followup changes are needed in plugins (Mostly those that define admin
monitors) and the design-library

* fix test

(cherry picked from commit 90a6ac5)
…nkinsci#9198)

* [JENKINS-72622] Rename CloudSet query parameter to avoid conflict

* [JENKINS-72622] Address SpotBugs warning

(cherry picked from commit eb65336)
@github-actions github-actions bot added the into-lts This PR is filed against an LTS branch label May 24, 2024
@krisstern krisstern force-pushed the feat/stable-2.452/backporting-2.452.2-1 branch from 508efd0 to 5078005 Compare May 24, 2024 18:23
@krisstern krisstern requested review from basil and daniel-beck May 25, 2024 02:47
…ST API or CLI (jenkinsci#9304)

[JENKINS-64553] call ItemListener after updating job via cli

when a job is updated via REST API or CLI, the
ItemListener.fireOnUpdated is now called to inform about the change.

(cherry picked from commit dae1737)
@krisstern krisstern merged commit 1a0abde into jenkinsci:stable-2.452 May 29, 2024
17 checks passed
@krisstern krisstern deleted the feat/stable-2.452/backporting-2.452.2-1 branch May 29, 2024 12:45
@daniel-beck
Copy link
Member

JENKINS-73114 is a bad backport, see JENKINS-73301.

@jonesbusy
Copy link
Contributor

Any reason JENKINS-64553 is not part of release note ? https://www.jenkins.io/changelog-stable/#v2.452.2

I'm asking because I'm still facing this bug when updating an organization folder via JobDSL (So not sure if it's a backport issue on 2.452.2 or because there are still issue with update event)

Thanks!

@MarkEWaite
Copy link
Contributor

Any reason JENKINS-64553 is not part of release note ? https://www.jenkins.io/changelog-stable/#v2.452.2

I'm asking because I'm still facing this bug when updating an organization folder via JobDSL (So not sure if it's a backport issue on 2.452.2 or because there are still issue with update event)

Thanks!

Thanks for catching that mistake.

The change was backported in:

It is the first commit in the 2.452.2 backport pull request with SHA d87e891

It was missed when creating the changelog and when reviewing the changelog. I've added it to the changelog as:

MarkEWaite added a commit to jenkins-infra/jenkins.io that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
into-lts This PR is filed against an LTS branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants