Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-64356] fix legacyIds missing when creating jobs via REST API or CLI #9303

Merged
merged 2 commits into from
May 27, 2024

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented May 23, 2024

When creating jobs via the rest api or cli the call to onCreatedFromScratch was missing. This can lead to long startup times when many jobs are created this way.

See JENKINS-64356.

Testing done

Unit tests are no longer ignored and succeed

Proposed changelog entries

  • Improve startup performance when jobs have been created via REST API or command line interface.

Proposed upgrade guidelines

N/A

Submitter checklist

Before the changes are marked as ready-for-merge:

Maintainer checklist

… or cli

When creating jobs via the rest api or cli the call to
onCreatedFromScratch was missing. This can lead to long startup times
when many jobs are created this way.
@mawinter69 mawinter69 changed the title [JENKINS-64356] call onCreatedFromScratch after creating item via rest api or cli [JENKINS-64356] fix legacyIds missing when creating jobs via REST API or CLI May 23, 2024
@mawinter69 mawinter69 marked this pull request as ready for review May 23, 2024 23:00
@MarkEWaite MarkEWaite added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted bug For changelog: Minor bug. Will be listed after features and removed bug For changelog: Minor bug. Will be listed after features labels May 25, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite
Copy link
Contributor

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 25, 2024
@MarkEWaite MarkEWaite merged commit c46dc4b into jenkinsci:master May 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants