Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73166] Fix PKCS#12 certificate save to credentials #9284

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented May 17, 2024

JENKINS-73166 - Revert part of "Remove dead JS code (#9136)"

See JENKINS-73166 where it notes that the credentials code for certificates has a dependency on this JavaScript code. Without this JavaScript, an attempt to add a new certificate credential type using PKCS#12 will fail with an HTTP 404 error.

The replacement of YUI.log with console.log is not involved in the bug report, so it is retained in the code change.

This reverts part of commit 38fdae4.

Testing done

Confirmed with interactive testing that a PKCS#12 certificate cannot be added before this change and can be added after this change.

Proposed changelog entries

  • Allow PKCS 12 certificates to be added to the credentials store again. Regression in 2.453.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@zbynek

Before the changes are marked as ready-for-merge:

Maintainer checklist

https://issues.jenkins.io/browse/JENKINS-73166 notes that the credentials
code for certificates has a dependency on this JavaScript code.
Without this JavaScript, an attempt to add a new certificate credential
type using PKCS#12 will fail with an HTTP 404 error.

The replacement of YUI.log with console.log is not involved in the bug
report, so it is retained in the code change.

This reverts part of commit 932ab19c5448bb0afa46f60b93c245eb08e86b55.
@MarkEWaite MarkEWaite added the bug For changelog: Minor bug. Will be listed after features label May 17, 2024
@MarkEWaite MarkEWaite changed the title Revert part of 'Remove dead JS code (#9136)' [JENKINS-73166] Revert part of 'Remove dead JS code (#9136)' May 17, 2024
@MarkEWaite MarkEWaite changed the title [JENKINS-73166] Revert part of 'Remove dead JS code (#9136)' [JENKINS-73166] Fix PKCS#12 certificate save to credentials - Revert part of 'Remove dead JS code (#9136)' May 17, 2024
@MarkEWaite MarkEWaite changed the title [JENKINS-73166] Fix PKCS#12 certificate save to credentials - Revert part of 'Remove dead JS code (#9136)' [JENKINS-73166] Fix PKCS#12 certificate save to credentials May 17, 2024
@MarkEWaite
Copy link
Contributor Author

Closing in favor of the much better solution in:

@MarkEWaite MarkEWaite closed this May 17, 2024
@MarkEWaite MarkEWaite deleted the revert-part-of-remove-dead-js-code branch May 17, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant