move the add/edit description button to the app-bar

[mawinter69]

So far the add/edit description button is rendered on its own line to the far right. This leads to additional space between the description or the title and the following content.

This change moves the add/edit description button to the app-bar where applicable (jobs, runs, computers, users and labels). For views it stays as it is as they don't have a title/app-bar. One also can't just allow to change the description via the configure page as the All View has no configure page.

The change is backwards compatible so plugins using the editableDescription taglib will work as before.

Requires changes in Matrix-project and maven-project plugins to align the new layout

Before/after:

Job:

Before:

After:

A pipeline job:

Run:

Before:

After:

After clicking the Add Description button

User:

Before:

After:

Computer:

Before:

After:

Label:

Before:

After:

Testing done

Manual Testing

Proposed changelog entries

• Move Add/Edit description to app bar.

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[mawinter69]

Some questions to think about

• make the add/edit description button a secondary button?
• should I directly create an overflow button that takes add/edit description?

On the run page

• also move the keep build forever to overflow?
• move the info about when the build started and how long it took to the left like e.g. the info about the cause.

[mawinter69]

@jenkinsci/sig-ux

[janfaracik]

Like it 👍

• make the add/edit description button a secondary button?

Seems sensible yeah.

• should I directly create an overflow button that takes add/edit description?

Could do, I do wonder how much benefit/use the 'Add description' button gets to warrant it existing - rather than just existing in the 'Configure' page.

• also move the keep build forever to overflow?

Sounds good.

• move the info about when the build started and how long it took to the left like e.g. the info about the cause.

Want to eventually move this section into its own extendable card (in a similar fashion to https://jenkins-redesign.vercel.app/project/build/375). I don't think the current summary components are the best use of space.

[mawinter69]

Like it 👍

• make the add/edit description button a secondary button?

Seems sensible yeah.

• should I directly create an overflow button that takes add/edit description?

Could do, I do wonder how much benefit/use the 'Add description' button gets to warrant it existing - rather than just existing in the 'Configure' page.

• also move the keep build forever to overflow?

Sounds good.

• move the info about when the build started and how long it took to the left like e.g. the info about the cause.

Want to eventually move this section into its own extendable card (in a similar fashion to https://jenkins-redesign.vercel.app/project/build/375). I don't think the current summary components are the best use of space.

For now I only made the description button a secondary button.

[Kevin-CB]

LGTM security wise

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!