Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73158] avoid jumping layout due to tooltips #9263

Merged
merged 3 commits into from
May 17, 2024

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented May 11, 2024

The fix for JENKINS-72744 made the tooltip get appended to the parent element. But this can also cause troubles in some cases. To avoid this one can now decide whether the tooltip should be appended to the body (the default) or to the parent.
Adjust all locations where a tooltip is displayed inside a widget to append it to the parent. This works well with those tooltips and avoids a jumping layout in the custom-folder-icon and potentially other places.

See JENKINS-73158.

Testing done

Manual testing that in widgets the tooltips are properly removed while with custom-folder-icon plugin, the layout stays stable.

Proposed changelog entries

  • Avoid jumping layout due to tooltips.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

The fix for JENKINS-72744 made the tooltip get appended to the parent
element. But this can also cause troubles in some cases.
To avoid this one can now decide whether the tooltip should be appended
to the body (the default) or to the parent.
Adjust all locations where a tooltip is displayed inside a widget to
append it to the parent. This works well with those tooltips and avoids
a jumping layout in the custom-folder-icon and potentially other places.
@NotMyFault NotMyFault added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label May 12, 2024
@timja
Copy link
Member

timja commented May 16, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 16, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in my interactive testing both with custom folder icon and without.

@MarkEWaite MarkEWaite merged commit 5089ad5 into jenkinsci:master May 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants