Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73047] Fix weather icons #9227

Merged
merged 1 commit into from
May 30, 2024

Conversation

SNanda8895
Copy link
Contributor

@SNanda8895 SNanda8895 commented May 3, 2024

See JENKINS-73047.

Testing done

I tested it locally ,everything worked fine.

Screenshot 2024-05-24 at 5 01 40 PM Screenshot 2024-05-24 at 5 01 58 PM Screenshot 2024-05-24 at 4 57 05 PM Screenshot 2024-05-24 at 4 57 40 PM Screenshot 2024-05-24 at 5 16 29 PM Screenshot 2024-05-24 at 5 17 45 PM

Proposed changelog entries

  • Fix stoke width of weather icons in Safari.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@Kevin-CB
@daniel-beck

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link

welcome bot commented May 3, 2024

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@NotMyFault NotMyFault requested a review from a team May 4, 2024 08:08
@NotMyFault NotMyFault added regression-fix Pull request that fixes a regression in one of the previous Jenkins releases web-ui The PR includes WebUI changes which may need special expertise labels May 4, 2024
@yaroslavafenkin yaroslavafenkin added the security-approved @jenkinsci/core-security-review reviewed this PR for security issues label May 7, 2024
@Luckybangar
Copy link

ok

Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good as far as I understand it.

@SNanda8895 Could you confirm testing in all supported browsers looked OK with and without zoom applied (ideally by providing screenshots for each combination)? Given this issue occurred only in one browser and with zoom applied, we'd like to prevent causing regressions in other browsers. These are the supported browsers.

Additionally, please provide a suggested changelog entry. See the changelog styleguide for guidance and previous entries for examples.

@daniel-beck daniel-beck self-requested a review May 27, 2024 08:05
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the screenshots.

@timja timja added bug For changelog: Minor bug. Will be listed after features and removed regression-fix Pull request that fixes a regression in one of the previous Jenkins releases labels May 28, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 28, 2024
@NotMyFault NotMyFault merged commit ee22f8b into jenkinsci:master May 30, 2024
16 checks passed
Copy link

welcome bot commented May 30, 2024

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.


MarkEWaite pushed a commit to MarkEWaite/jenkins that referenced this pull request Jun 6, 2024
Fix weather icons

(cherry picked from commit ee22f8b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback security-approved @jenkinsci/core-security-review reviewed this PR for security issues web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants