-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display how many users there are on the 'Users' page #9221
Conversation
Don't we use badges in other areas for the same thing? When should I use a badge and when this new style? It makes sense to clarify in the design library? |
Opened a PR for the design library here - jenkinsci/design-library-plugin#325. Gist is show a badge in the side panel for important info/info the user might need to take action on (e.g. updates, test success/failures) and show that in the app bar if that makes sense too. In this instance the number of users isn't important unless you're on this page, so there isn't value in showing it outside of this page as a badge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
Tiny one to show how many users there are on the 'Users' page. Follows the same pattern as the prototype.
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist