Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Locale.ROOT when use String.toLowerCase #9162

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

BobDu
Copy link
Member

@BobDu BobDu commented Apr 12, 2024

See #9044 (comment)

Testing done

Automated tests pass

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

@BobDu BobDu force-pushed the use-locale-root branch from 5ffaf44 to ad30376 Compare April 12, 2024 18:38
@NotMyFault NotMyFault requested a review from a team April 12, 2024 19:03
@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Apr 12, 2024
@timja
Copy link
Member

timja commented Apr 16, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 16, 2024
@MarkEWaite MarkEWaite merged commit aa7ac0b into jenkinsci:master Apr 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants