Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-70246] Unexpectedly wide sidepanel #9133

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

timja
Copy link
Member

@timja timja commented Apr 6, 2024

See JENKINS-70246.

image

Testing done

Checked on a variety of device sizes using chrome device emulator, ipad mini, ipad pro, surface pro, etc

Proposed changelog entries

  • Adjust side panel sizes for certain screens like iPad Pro.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@timja timja added web-ui The PR includes WebUI changes which may need special expertise bug For changelog: Minor bug. Will be listed after features labels Apr 6, 2024
@timja timja requested review from a team and janfaracik April 6, 2024 18:54
@timja timja requested a review from zbynek April 7, 2024 07:04
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timja
Copy link
Member Author

timja commented Apr 7, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 7, 2024
@NotMyFault NotMyFault merged commit 97a44a4 into jenkinsci:master Apr 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants