Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Edit build information page #9132

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

timja
Copy link
Member

@timja timja commented Apr 6, 2024

  • Add title to edit build information
  • Fix display name label for english, previously it was the localisation key DisplayName

I've checked and pipeline is using the same page so this has fixed it for both freestyle and pipeline

Before:
image

After:
image

Testing done

Proposed changelog entries

  • Improve edit build information page.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@timja timja added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Apr 6, 2024
@timja timja requested a review from a team April 6, 2024 18:25
@timja timja requested a review from a team April 7, 2024 09:27
@timja
Copy link
Member Author

timja commented Apr 7, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 7, 2024
@NotMyFault NotMyFault merged commit 9c05772 into jenkinsci:master Apr 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants