Use 'jenkins-button' for tables

[janfaracik]

Small one to replace .jenkins-table__button with just .jenkins-button. The two classes are super similar and we're not getting any advantages from having them separated.

Couple of visual changes:

• Buttons with a colour applied to them now reflect the colour in the buttons background

Before

After

• Buttons are slightly bubblier/rounded

Testing done

• All buttons in core have had their classes changed and look as expected

Proposed changelog entries

• N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[timja]

LGTM, I checked the changes here and I looked for any plugins that looked funny and didn't find any but the class hasn't been removed so I wouldn't expect any

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[mawinter69]

This causes a regression. The buttons in tables are then no longer resized when the icon size is changed.
The background of the button is also flowing over the row border
Also there is now hardly any difference in icon size between large and medium table size
Small icons:

Medium icons

Large icons:

[MarkEWaite]

Thanks for the comment @mawinter69 . This will first be visible to LTS users in Jenkins 2.462.1 that is scheduled to release 7 Oct 2024. The impact of the issues does not seem very severe to me, but I agree that it is a change of behavior and it is unexpected that small, medium, and large have very little difference now.

If a fix is provided, should it also be considered for a backport?

If a backport is needed, then an issue needs to be created on https://issues.jenkins.io so that it can be marked as an LTS candidate.

[mawinter69]

Created https://issues.jenkins.io/browse/JENKINS-73453

[mawinter69]

caused JENKINS-73668