Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set current object to be the administrative monitor itself when loading its description view #9071

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Mar 25, 2024

This allows to reference a method from the administrative monitor instance.

All instances of administrative monitor I could find use boilerplate ${%blurb} with a corresponding resource bundle so this won't have any impact to them, while allowing more flexible ways of providing descriptions.

Testing done

Exercised by various administrative monitors in CloudBees CI, limiting the number of files to create to add a new administrative monitor.

Proposed changelog entries

  • Provide current administrative monitor as context object when loading its description.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@Vlatombe Vlatombe added developer Changes which impact plugin developers skip-changelog Should not be shown in the changelog and removed skip-changelog Should not be shown in the changelog labels Mar 25, 2024
@Vlatombe Vlatombe requested review from jglick, a team and julieheard March 25, 2024 09:42
Co-authored-by: Jesse Glick <[email protected]>
@timja
Copy link
Member

timja commented Mar 25, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 25, 2024
@daniel-beck daniel-beck added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Mar 26, 2024
@MarkEWaite MarkEWaite merged commit f7bbcb5 into jenkinsci:master Mar 26, 2024
17 checks passed
@Vlatombe Vlatombe deleted the administrative-monitor-context branch August 12, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants