Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CloudList.setOwner call from Jenkins.loadTasks to load #8976

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Feb 20, 2024

In CloudBees CI we noticed an issue whereby after reloading $JENKINS_HOME/config.xml via Jenkins.load() (exposed as Loadable in #8544), Jenkins.clouds had a blank (NOOP) owner. This meant that subsequent changes to the cloud list were not saved. loadTasks (which calls load in its loadJenkins task) fixed up the owner but just load did not.

Testing done

Covered by a regression test in CloudBees CI. I could try to construct something analogous here though I am not sure how compelling it would be out of context.

Proposed changelog entries

  • Setting a proper owner for Jenkins.clouds after Jenkins.load().

Before the changes are marked as ready-for-merge:

Maintainer checklist

@NotMyFault NotMyFault added the bug For changelog: Minor bug. Will be listed after features label Feb 27, 2024
@NotMyFault
Copy link
Member

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 27, 2024
@NotMyFault NotMyFault merged commit 20263d0 into jenkinsci:master Feb 28, 2024
17 checks passed
@jglick jglick deleted the CloudList.setOwner branch February 28, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants