Move CloudList.setOwner
call from Jenkins.loadTasks
to load
#8976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CloudBees CI we noticed an issue whereby after reloading
$JENKINS_HOME/config.xml
viaJenkins.load()
(exposed asLoadable
in #8544),Jenkins.clouds
had a blank (NOOP
)owner
. This meant that subsequent changes to the cloud list were not saved.loadTasks
(which callsload
in itsloadJenkins
task) fixed up the owner but justload
did not.Testing done
Covered by a regression test in CloudBees CI. I could try to construct something analogous here though I am not sure how compelling it would be out of context.
Proposed changelog entries
Jenkins.clouds
afterJenkins.load()
.Before the changes are marked as
ready-for-merge
:Maintainer checklist