Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI for plugin manager's Advanced settings with SystemRead #8942

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Feb 7, 2024

Noticed while playing with SystemRead: #6886 did not take into account users with Overall/SystemRead permission and the changed UI shown to them.

Testing done

Navigate to /pluginManager/advanced with SystemRead permission and confirm no link shows, no JS error.

Screenshot 2024-02-07 at 21 44 54
Before
Screenshot 2024-02-07 at 21 50 25

Proposed changelog entries

too minor

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@daniel-beck daniel-beck changed the title Fix UI for plugin manager's Advanced settings with ExtendedRead Fix UI for plugin manager's Advanced settings with SystemRead Feb 7, 2024
@NotMyFault NotMyFault requested a review from a team February 8, 2024 08:59
@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Feb 8, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 8, 2024
@NotMyFault NotMyFault merged commit 76df167 into jenkinsci:master Feb 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants