Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new index page for heap dump creation #8929

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

daniel-beck
Copy link
Member

Screenshot

Two small improvements to /heapDump:

  • Create a page explaining the heap dump download a bit and a known limitation.
  • Require POST to download heapDump.hprof. Not addressing a security issue, just seems nicer.

This does not address the following remaining issues (which can be done later):

  • Discoverability (e.g. linking from /systemInfo and corresponding agent pages, or directly integrating it there)
  • Determine beforehand whether it would succeed, and only offer download option if it is.

Testing done

  1. Navigated to /heapDump and clicked the button. Download started.
  2. Navigated to /computer/a1/heapDump of a connected agent, and clicked the button. Download started.
  3. Navigated to /heapDump/heapDump.hprof (from @RequirePOST)and clicked the button. Download started.
  4. Navigated to /computer/a1/heapDump/heapDump.hprof (from @RequirePOST)and clicked the button. Download started.

Proposed changelog entries

  • Create an index page for heap dump creation.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@NotMyFault NotMyFault added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Feb 2, 2024
@NotMyFault NotMyFault requested a review from a team February 5, 2024 16:13
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 6, 2024
@NotMyFault NotMyFault merged commit b8236f8 into jenkinsci:master Feb 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants