Create new index page for heap dump creation #8929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small improvements to
/heapDump
:heapDump.hprof
. Not addressing a security issue, just seems nicer.This does not address the following remaining issues (which can be done later):
/systemInfo
and corresponding agent pages, or directly integrating it there)Testing done
/heapDump
and clicked the button. Download started./computer/a1/heapDump
of a connected agent, and clicked the button. Download started./heapDump/heapDump.hprof
(from@RequirePOST
)and clicked the button. Download started./computer/a1/heapDump/heapDump.hprof
(from@RequirePOST
)and clicked the button. Download started.Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist