Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72636] Prevent authenticated access to Resource Root URL #8922

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

daniel-beck
Copy link
Member

Resource Root URL is for unauthenticated use, that's the entire point of it. Authenticated access means something has gone wrong, so prevent it.

See JENKINS-72636.

Testing done

Basically what the autotests confirm: curl -u admin:token or curl -u admin:pwd get HTTP 400 errors.

Proposed changelog entries

  • Prevent authenticated access to Resource Root URL

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@NotMyFault NotMyFault added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Feb 1, 2024
@NotMyFault NotMyFault requested a review from a team February 1, 2024 07:54
@timja
Copy link
Member

timja commented Feb 1, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 1, 2024
@NotMyFault NotMyFault merged commit 3ad945f into jenkinsci:master Feb 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants