Missing VirtualFile.run usage in DirectoryBrowserSupport

[jglick]

I found a failing test in artifact-manager-s3 during a routine dependency bump including a core version change, and bisected the failure to a security fix 8045266. This neglected to use VirtualFile.run to batch together file metadata operations, causing the number of S3 API calls in the test case to jump from 13 to 37. A simple reorganization of method calls restores the previous behavior so far as this test case is concerned.

Testing done

jenkinsci/artifact-manager-s3-plugin#450 (comment)

Proposed changelog entries

• A security fix in 2.394 caused a substantial slowdown in displaying build artifacts when using remote artifact managers such as in S3.

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[daniel-beck]

Looks reasonable, thanks! Haven't manually tested.

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[MarkEWaite]

Included in Jenkins 2.443