[JENKINS-72407] missing folder icon

[mawinter69]

when a folder icon is provided and relies on the getImageOf method this leads to a missing icon, e.g. gitlab branch source or when using a custom folder icon
So fall back to the ballColorTd when we have no iconname which handles all cases properly.

See JENKINS-72407.

Testing done

• Install custom-folder-icon plugin,
• create folder and configure it to use a custom icon
• go to jenkins root dashboard, the icon should be properly shown

Proposed changelog entries

• JENKINS-72407, fix missing folder icons

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[Pldi23]

I manually tested use cases reported in https://issues.jenkins.io/browse/JENKINS-72576, the fix works fine. Thank you.

[NotMyFault]

/label ready-for-merge

---

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

[aneveux]

Hello 👋

I see in the JENKINS-72407 jira ticket that this issue is labeled with lts-candidate. Does this mean that this Pull Request will be backported to a 2.440.1 version of Jenkins for the February release?

ping @MarkEWaite who merged this Pull Request.

Thanks a lot for the info!

[MarkEWaite]

I see in the JENKINS-72407 jira ticket that this issue is labeled with lts-candidate. Does this mean that this Pull Request will be backported to a 2.440.1 version of Jenkins for the February release?

Thanks for asking. Yes, the intent is that it should be backported to 2.440.1 along with the security fixes.

The Jenkins 2.440.1 LTS release checklist is available as:

• 2.440.1 Release checklist jenkins-infra/release#497

There is one more pull request that is not yet merged by but that I believe should be backported to 2.440.1.

• [JENKINS-72505] f:validateButton finds selected radio button #8832 the fix for https://issues.jenkins.io/browse/JENKINS-72505

[aneveux]

Awesome! Thanks a lot @MarkEWaite ❤️

[MarkEWaite]

@aneveux I'd love it if you could review the other pending pull request.

• [JENKINS-72505] f:validateButton finds selected radio button #8832