Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72540] FilePath.copyRecursiveTo() copying now also if local and remote have incompatible character sets at binary level #8860

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

lne3
Copy link
Contributor

@lne3 lne3 commented Jan 12, 2024

See JENKINS-72540.

Testing done

  • The pipeline-maven-plugin's 'Generated Artifacts Publisher' that had been originally failing (see JENKINS-72540) had been re-run successfully on an z/OS agent with default character set CP1047.
  • existing integration test on a linux machine
  • no automated test provided as reproducing the issue requires a remote with default character set CP1047

Proposed changelog entries

  • Allow recursive remote file copy even if local and remote nodes have incompatible character sets at binary level, e.g. ISO-8859-1 and CP1047.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

lne3 added 2 commits January 12, 2024 17:04
For JENKINS-72540 only needed for tar, but changed zip for consistency as well.
such that local and remote understand each other
Otherwise, if remote is z/OS with native EBCDIC encoding the file names
will be in EBCDIC and fails reading
Copy link

welcome bot commented Jan 12, 2024

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@NotMyFault NotMyFault added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jan 13, 2024
@NotMyFault NotMyFault requested a review from a team January 13, 2024 08:50
@NotMyFault NotMyFault changed the title FilePath.copyRecursiveTo() copying now also if local and remote have incompatible character sets at binary level [JENKINS-72540] FilePath.copyRecursiveTo() copying now also if local and remote have incompatible character sets at binary level Mar 4, 2024
@NotMyFault NotMyFault requested a review from a team March 4, 2024 14:49
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 4, 2024
@NotMyFault NotMyFault merged commit 9f68c18 into jenkinsci:master Mar 5, 2024
16 checks passed
Copy link

welcome bot commented Mar 5, 2024

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants