Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated -jnlpUrl in JNLPLauncherTest #8833

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

basil
Copy link
Member

@basil basil commented Jan 5, 2024

This test was using a deprecated argument. Rewrote the test to use the non-deprecated replacement.

Testing done

mvn clean verify -Dtest=hudson.slaves.JNLPLauncherTest

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@basil basil added the tests This PR adds/removes/updates test cases label Jan 5, 2024
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 5, 2024
@MarkEWaite MarkEWaite added the skip-changelog Should not be shown in the changelog label Jan 5, 2024
@MarkEWaite MarkEWaite self-assigned this Jan 5, 2024
@MarkEWaite MarkEWaite merged commit 7392571 into jenkinsci:master Jan 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog tests This PR adds/removes/updates test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants