Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an 'Appearance' category to the wizard #8822

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

NotMyFault
Copy link
Member

The change proposed adds an "Appearance" category to the setup wizard's plugin category, listing a few active developed plugins changing the look and feel of Jenkins.

The dark theme plugin is selected as default, given it adds a significant value to Jenkins' appearance and integrates smooth by respecting the users' browser and OS theme if configured, no longer hurting your eyes when working in the late hours ;)

Testing done

The new category appears in the sidebar of the setup wizard, and the dark theme plugin is selected as intended.

Screenshot 2024-01-03 at 11 08 27

Proposed changelog entries

  • Add an 'Appearance' category to the setup wizard.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@NotMyFault NotMyFault added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jan 3, 2024
@NotMyFault NotMyFault requested a review from a team January 3, 2024 10:15
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks for this!

@NotMyFault NotMyFault requested a review from janfaracik January 3, 2024 22:52
@NotMyFault
Copy link
Member Author

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 4, 2024
@NotMyFault NotMyFault requested a review from daniel-beck January 4, 2024 15:15
@NotMyFault NotMyFault dismissed daniel-beck’s stale review January 4, 2024 22:00

Changes addressed

@NotMyFault NotMyFault force-pushed the add-appearance-category branch from aca3bc5 to 3a5fb2c Compare January 4, 2024 22:02
@timja timja merged commit 90b8ed9 into jenkinsci:master Jan 5, 2024
14 of 16 checks passed
@NotMyFault NotMyFault deleted the add-appearance-category branch January 6, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants