Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XML namespace schemaLocation #8817

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Jan 1, 2024

While using the maven tidy plugin in another repository, I noticed that not only the POM has been tidied, but the XML namespace location has been changed too.

Given this is a trivial change because http://maven.apache.org/maven-v4_0_0.xsd redirects to https://maven.apache.org/xsd/maven-4.0.0.xsd, I'd propose we update it still, to align with the maven POM code convention and are prepared in case the redirect stops working some day.

Testing done

Compiling Jenkins works as-is.

Proposed changelog entries

  • JENKINS-XXXXX, human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Jan 1, 2024
@timja timja merged commit 4c423d4 into jenkinsci:master Jan 2, 2024
16 checks passed
@@ -22,7 +22,7 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
-->
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MNG-6778 FTR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NotMyFault NotMyFault deleted the update-xmlns-schematLocation branch January 2, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants