Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71666] Adapt to Popper deprecation in Jenkins core #8810

Merged
merged 2 commits into from
Jan 2, 2024
Merged

[JENKINS-71666] Adapt to Popper deprecation in Jenkins core #8810

merged 2 commits into from
Jan 2, 2024

Conversation

debayangg
Copy link
Contributor

@debayangg debayangg commented Dec 29, 2023

See JENKINS-71666. It removes the deprecated Popper api from war/pom.xml.

Testing done

Tests passed
Note: Only light-test was performed

Proposed changelog entries

  • Remove deprecated Popper API.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@MarkEWaite @NotMyFault

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link

welcome bot commented Dec 29, 2023

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@MarkEWaite MarkEWaite added the skip-changelog Should not be shown in the changelog label Dec 29, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite self-assigned this Dec 29, 2023
@MarkEWaite
Copy link
Contributor

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

@MarkEWaite MarkEWaite added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 1, 2024
@MarkEWaite MarkEWaite merged commit c878487 into jenkinsci:master Jan 2, 2024
17 checks passed
Copy link

welcome bot commented Jan 2, 2024

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.


@basil
Copy link
Member

basil commented Jan 2, 2024

Testing done
Tests passed
Note: Only light-test was performed

In general, any changes to the list of detached plugins should be tested as in e.g. #8724:

Ran mvn clean verify -Dtest=jenkins.install.LoadDetachedPluginsTest,jenkins.model.StartupTest (including un-ignored LoadDetachedPluginsTest#noUpdateSiteWarnings) locally.

LoadDetachedPluginsTest#noUpdateSiteWarnings is an important test for detached plugins, but it is not run as part of normal automation because otherwise new security warnings would fail unrelated builds.

As a one-time courtesy, I have run this test locally and verified that it passed. In the future, please ensure that proper testing is done as part of the review process.

@MarkEWaite
Copy link
Contributor

In the future, please ensure that proper testing is done as part of the review process.

Will do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants