Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notifying badges in dropdowns #8798

Closed

Conversation

SomasekharSunkari
Copy link
Contributor

See JENKINS-71326.

Testing done

Screenshot 2023-12-21 145143 Screenshot 2023-12-21 150118

Proposed changelog entries

#If any changes need to made tell me ! if it was not enough ! Thank You !

Copy link
Contributor

@mawinter69 mawinter69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs more than just changing the color to orange. The badges can have different colors, that correspond to the severity of the badge (danger=red, warning=orange, info=blue). And this should be also visible in the dropdowns accordingly.

@daniel-beck
Copy link
Member

Also needs to consider theme support (e.g. https://plugins.jenkins.io/dark-theme/ )

@SomasekharSunkari
Copy link
Contributor Author

Ok I will update this thing . Thank you!

@mawinter69
Copy link
Contributor

while working on badges, <l:task in sidepanels also supports badges. Those should also get coloured.
image

@SomasekharSunkari
Copy link
Contributor Author

how to fix codeing styles with prettier ? can anyone guide.

@krisstern
Copy link
Member

Hi @SomasekharSunkari,
Maybe try setting up prettier for Java: https://github.com/jhipster/prettier-java? You will need to define some rules though to begin with.

@krisstern krisstern changed the title Notifying badges in dropdowns are updated Update notifying badges in dropdowns Jan 22, 2024
@SomasekharSunkari
Copy link
Contributor Author

Can you tell me the rules to define with it ?

@mawinter69
Copy link
Contributor

This PR is obsolete, we already have another PR #8853 that is basically ready

@krisstern
Copy link
Member

Cool 👍🏼

@krisstern krisstern closed this Jan 22, 2024
@SomasekharSunkari
Copy link
Contributor Author

Ok I will move to another !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants