-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notifying badges in dropdowns #8798
Update notifying badges in dropdowns #8798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it needs more than just changing the color to orange. The badges can have different colors, that correspond to the severity of the badge (danger=red, warning=orange, info=blue). And this should be also visible in the dropdowns accordingly.
Also needs to consider theme support (e.g. https://plugins.jenkins.io/dark-theme/ ) |
Ok I will update this thing . Thank you! |
how to fix codeing styles with prettier ? can anyone guide. |
Hi @SomasekharSunkari, |
Can you tell me the rules to define with it ? |
This PR is obsolete, we already have another PR #8853 that is basically ready |
Cool 👍🏼 |
Ok I will move to another ! |
See JENKINS-71326.
Testing done
Proposed changelog entries
#If any changes need to made tell me ! if it was not enough ! Thank You !