-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry for basic Java system properties #8787
Add telemetry for basic Java system properties #8787
Conversation
1a73ddc
to
687145a
Compare
@@ -48,7 +48,7 @@ | |||
<j:if test="${not collector.end.isBefore(now)}"> | |||
<dt>${collector.displayName}</dt> | |||
<dd> | |||
<st:include from="${collector}" optional="true" page="description.jelly"/> | |||
<st:include it="${collector}" optional="true" page="description.jelly"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required to be able to access it
(the current Telemetry
implementation) in description.jelly
.
core/src/main/java/jenkins/telemetry/impl/JavaSystemProperties.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!
This could be useful to collect. There is some overlap with the general usage stats (so not all of this will be new), and it doesn't get agent JVM information, but still. I think this tells us more about OS and JVM than what we currently know.
Testing done
No dedicated autotest due to the similarity with other similar telemetry implementations.
Output:
On Configure System, the help shows as expected:
Ran
ExtensionList.lookupSingleton(jenkins.telemetry.Telemetry$TelemetryReporter).run()
and confirmed it shows up in Uplink.Added a
test
property to the list to ensure it renders correctly:Why even test for
null
? While I expect it to always exist, https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/System.html#getProperties() doesn't listfile.encoding
as part of the default set, so I added this to be safe.Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist