Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements to Run related classes #8777

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

Vlatombe
Copy link
Member

These are logging improvements that were useful to investigate exotic Run loading issues.

Testing done

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@Vlatombe Vlatombe added skip-changelog Should not be shown in the changelog developer Changes which impact plugin developers labels Dec 13, 2023
@Vlatombe Vlatombe requested review from jglick and a team December 13, 2023 15:55
return null;
}
Job<?, ?> job = j.getItemByFullName(jobName, Job.class);
if (job == null) {
LOGGER.fine(() -> "no such job " + jobName + " when running as " + Jenkins.getAuthentication2().getName());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 common issue when using unexpected threads

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(could also/instead log from whatever code returns null when principal lacks READ)

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 13, 2023
@NotMyFault NotMyFault merged commit 302e6ac into jenkinsci:master Dec 14, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants