Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72288] fix nested job link in mobile view #8765

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Dec 8, 2023

when a view contains jobs that are from a nested folder, the links where not properly calculated.

See JENKINS-72288.

Testing done

  1. Create folder with 1 job inside
  2. create a list view in root that contains the job from the folder
  3. Resize window until it is so small that views are below the widgets
  4. click on job name

Proposed changelog entries

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

when a view contains jobs that are from a nested folder, the links where
not properly calculated.
@NotMyFault NotMyFault requested review from a team December 9, 2023 09:22
@NotMyFault NotMyFault added web-ui The PR includes WebUI changes which may need special expertise bug For changelog: Minor bug. Will be listed after features needs-security-review Awaiting review by a security team member labels Dec 9, 2023
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaroslavafenkin yaroslavafenkin added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Dec 11, 2023
@NotMyFault NotMyFault removed the request for review from a team December 12, 2023 07:03
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 12, 2023
@NotMyFault NotMyFault merged commit cc4e8e7 into jenkinsci:master Dec 13, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback security-approved @jenkinsci/core-security-review reviewed this PR for security issues web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants