Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-64356] Add test for missing legacyIds when creating jobs via REST API or CLI #8758

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

basil
Copy link
Member

@basil basil commented Dec 6, 2023

Add two simple test cases for JENKINS-64356 that demonstrate the problem, currently @Ignored because the production code is still buggy. I am not actually fixing the problem in this PR; the (hopefully very simple) fix of calling Item#onCreatedFromScratch can possibly be implemented by an interested new contributor who is looking for a bite-sized bug to get started with Jenkins development.

Testing done

Ran the tests without @Ignore and verified that they failed on the last line of the test as expected.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@basil basil added the tests This PR adds/removes/updates test cases label Dec 6, 2023
@basil basil requested a review from Dohbedoh December 6, 2023 19:49
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MarkEWaite
Copy link
Contributor

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

@MarkEWaite
Copy link
Contributor

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 20, 2023
@MarkEWaite MarkEWaite self-assigned this Dec 20, 2023
@MarkEWaite MarkEWaite merged commit b8ee997 into jenkinsci:master Dec 21, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback tests This PR adds/removes/updates test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants