Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid file locks in LauncherTest.remotable #8745

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Dec 4, 2023

Amending test introduced in #3563 since as noted in #8006 (comment) it can have file locking issues on Windows. Simplified as per jenkinsci/workflow-durable-task-step-plugin@4cf6db4.

Testing done

Passes locally on both Linux and Windows. (Could not reproduce failure on Windows but did not try hard.)

Proposed changelog entries

  • N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Dec 7, 2023
@NotMyFault
Copy link
Member

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 12, 2023
@NotMyFault NotMyFault merged commit 0a94979 into jenkinsci:master Dec 13, 2023
16 checks passed
@jglick jglick deleted the LauncherTest.remotable branch December 13, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants