Don't try to publish artifacts on RC GitHub releases

[lemeurherve]

This PR adds a condition to not run publication steps in the "Publish artifact" GitHub Action if the current version is a release candidate (ie ends with -SNAPSHOT) so the job doesn't fail, as RC versions aren't published on GitHub releases.

Related conversation during the 2.426.2 RC preparation in the #jenkinsci/release chat room: https://matrix.to/#/!JlkqzpdEnsUUuVtjgE:matrix.org/$rS0DQu7jyc6K6zo3L6c6gqeui97hZrzsWQPEkk8XfhI?via=gitter.im&via=matrix.org

See JENKINS-XXXXX.

Testing done

Tested on a fork.

Proposed changelog entries

No changelog entry, doesn't concern Core code.

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[NotMyFault]

Thanks!

[timja]

Is this right?
https://github.com/jenkinsci/jenkins/releases/tag/jenkins-2.426.2-rc-1

Won't that show 2.426.2-rc34281.a_b... ?

[lemeurherve]

The mvn command executed L28 returns the project.version from the pom.xml, which doesn't correspond to the tag.

https://github.com/jenkinsci/jenkins/pull/8733/files#diff-11648584ad8169da42bec78a0209137863ad69726133730cefff2f1eb66d20c4R28

jenkins/pom.xml

Lines 37 to 77 in 78f1e9c

	<version>${revision}${changelist}</version>
	<packaging>pom</packaging>
	<name>Jenkins main module</name>
	<description>The module that constitutes the main jenkins.war</description>
	<url>https://github.com/jenkinsci/jenkins</url>
	<licenses>
	<license>
	<name>The MIT license</name>
	<url>https://opensource.org/licenses/MIT</url>
	<distribution>repo</distribution>
	</license>
	</licenses>
	<modules>
	<module>bom</module>
	<module>websocket/spi</module>
	<module>websocket/jetty10</module>
	<module>core</module>
	<module>war</module>
	<module>test</module>
	<module>cli</module>
	<module>coverage</module>
	</modules>
	<scm child.scm.connection.inherit.append.path="false" child.scm.developerConnection.inherit.append.path="false" child.scm.url.inherit.append.path="false">
	<connection>scm:git:https://github.com/jenkinsci/jenkins.git</connection>
	<developerConnection>scm:git:[email protected]:jenkinsci/jenkins.git</developerConnection>
	<tag>${scmTag}</tag>
	<url>https://github.com/jenkinsci/jenkins</url>
	</scm>
	<issueManagement>
	<system>jira</system>
	<url>https://issues.jenkins.io/issues/?jql=component=15593</url>
	</issueManagement>
	<properties>
	<revision>2.435</revision>
	<changelist>-SNAPSHOT</changelist>