Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show node monitors on agent page #8725

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

mawinter69
Copy link
Contributor

add an advanced button on the agent page. When clicking it will show the node monitors for this agent including any warnings/errors

image

Testing done

Connect an agent and then visit agent page

Proposed changelog entries

  • show monitoring data on agent page

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

add an advanced button on the agent page. When clicking it will show the
node monitors for this agent including any warnings/errors
@NotMyFault NotMyFault requested review from a team December 1, 2023 21:13
@NotMyFault NotMyFault added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted needs-security-review Awaiting review by a security team member needs-ath-build Needs to run through the full acceptance-test-harness suite labels Dec 1, 2023
@yaroslavafenkin yaroslavafenkin added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Dec 11, 2023
@NotMyFault NotMyFault removed the request for review from a team December 12, 2023 07:06
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@NotMyFault NotMyFault requested a review from a team December 12, 2023 07:06
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and seems useful.

I guess the somewhat odd presentation is necessary because of table cell reuse?

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 12, 2023
@NotMyFault NotMyFault merged commit 64dc384 into jenkinsci:master Dec 13, 2023
17 checks passed
@NotMyFault NotMyFault removed the needs-ath-build Needs to run through the full acceptance-test-harness suite label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted security-approved @jenkinsci/core-security-review reviewed this PR for security issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants