Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to timeline widget in build history #8718

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

janfaracik
Copy link
Contributor

Small one - the 'time since' column is clickable and throws an error as it tries to call the now removed timeline widget. This PR removes the click event fixing that issue.

Testing done

  • The issue no longer occurs

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkins-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@timja timja requested a review from a team November 24, 2023 22:16
@timja timja added the skip-changelog Should not be shown in the changelog label Nov 24, 2023
@timja timja requested a review from a team November 24, 2023 22:16
@NotMyFault NotMyFault requested a review from a team November 25, 2023 11:33
@NotMyFault NotMyFault added the needs-security-review Awaiting review by a security team member label Nov 25, 2023
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, and thanks for taking care of this!

@daniel-beck daniel-beck added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Nov 27, 2023
@timja
Copy link
Member

timja commented Nov 27, 2023

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 27, 2023
@NotMyFault NotMyFault merged commit 37622ec into jenkinsci:master Nov 28, 2023
17 checks passed
@timja timja deleted the remove-timeline-reference branch November 29, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback security-approved @jenkinsci/core-security-review reviewed this PR for security issues skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants