-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added validation of FIPS password length #8694
Added validation of FIPS password length #8694
Conversation
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
Co-authored-by: Daniel Beck <[email protected]>
Issue created in Jenkins.io - https://issues.jenkins.io/browse/JENKINS-72332 |
Please restore the pull request template https://github.com/jenkinsci/jenkins/blob/master/.github/PULL_REQUEST_TEMPLATE.md |
core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But @Santhosh-CloudB you need to restore the template to have proper release notes, link to Jira etc..
Thanks
done |
|
@timja @daniel-beck, this looks to be good to merge now. Or something else you want to be changed? |
The changelog template is broken please just copy and paste the whole template back in as text and edit it appropriately |
@timja should be better now. @Santhosh-CloudB I fixed the description with the changelog template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.
Thanks!
@timja - Looks its not merged yet. can you pls merge it? |
Congratulations on getting your very first Jenkins core pull request merged 🎉🥳 |
See JENKINS-72332.
Testing done
FIPS Enabled Jenkins requires password to be 112 bits(14 chars) minimum. While creating a User, when the password is short, it was showing error in console and navigating to error page. Now a validation has been added to check the password length.
The error couldnt be caught since its unchecked exception and its been caused in the line of code where framework's encode method is called.this doesnt allow adding a new exception apart from the one defined in the interface.
Testing has been done in FIPS enabled Docker container.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist