Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation of FIPS password length #8694

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

Santhosh-CloudB
Copy link
Contributor

@Santhosh-CloudB Santhosh-CloudB commented Nov 15, 2023

See JENKINS-72332.

Testing done

FIPS Enabled Jenkins requires password to be 112 bits(14 chars) minimum. While creating a User, when the password is short, it was showing error in console and navigating to error page. Now a validation has been added to check the password length.

The error couldnt be caught since its unchecked exception and its been caused in the line of code where framework's encode method is called.this doesnt allow adding a new exception apart from the one defined in the interface.

Testing has been done in FIPS enabled Docker container.

Proposed changelog entries

  • Fips mode now requires a minimum of 14 characters for a password.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link

welcome bot commented Nov 15, 2023

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@Santhosh-CloudB
Copy link
Contributor Author

Issue created in Jenkins.io - https://issues.jenkins.io/browse/JENKINS-72332

@timja timja added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Nov 16, 2023
@timja
Copy link
Member

timja commented Nov 16, 2023

@olamy olamy added the fips label Nov 17, 2023
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But @Santhosh-CloudB you need to restore the template to have proper release notes, link to Jira etc..
Thanks

@Santhosh-CloudB
Copy link
Contributor Author

@Santhosh-CloudB
Copy link
Contributor Author

done

@olamy
Copy link
Member

olamy commented Nov 23, 2023

@timja @daniel-beck, this looks to be good to merge now. Or something else you want to be changed?
Thanks

@timja
Copy link
Member

timja commented Nov 23, 2023

The changelog template is broken please just copy and paste the whole template back in as text and edit it appropriately

@olamy
Copy link
Member

olamy commented Nov 23, 2023

The changelog template is broken please just copy and paste the whole template back in as text and edit it appropriately

@timja should be better now.

@Santhosh-CloudB I fixed the description with the changelog template

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 23, 2023
@Santhosh-CloudB
Copy link
Contributor Author

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@timja - Looks its not merged yet. can you pls merge it?

@timja timja merged commit f9f542b into jenkinsci:master Nov 27, 2023
17 checks passed
@timja timja changed the title added validation of FIPS password length Added validation of FIPS password length Nov 27, 2023
Copy link

welcome bot commented Nov 27, 2023

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fips ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants