Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverted fixes for FILEUPLOAD-293 #8678

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

StefanSpieker
Copy link
Contributor

reverted fixes for FILEUPLOAD-293 since this was fixed in Commons-FileUpload 1.5

I'm not sure if it should be a changlog entry or not.

Testing done

I verified that after removing the fix, following isue couldn't be reproduced: JENKINS-65327

Proposed changelog entries

  • removed fixes after available in upstream Commons Fileupload

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@NotMyFault NotMyFault added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Nov 5, 2023
@NotMyFault NotMyFault requested a review from a team November 5, 2023 10:19
@NotMyFault NotMyFault added skip-changelog Should not be shown in the changelog and removed rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Nov 5, 2023
@MarkEWaite
Copy link
Contributor

I've confirmed that I can see the test failures consistently on my RHEL 8 with Java 11 when using this pull request, but don't see those failures when I run the same command from the master branch. The command that I run is:

mvn -Dtest=PluginManagerTest clean verify

@StefanSpieker
Copy link
Contributor Author

Thanks @MarkEWaite

@StefanSpieker StefanSpieker marked this pull request as draft November 5, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants