-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish French translations for Update Center #8672
Finish French translations for Update Center #8672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They seem reasonable to me. I checked translate.google.com to convert them back to my native language (English) and the resulting English translation is good.
Would like one of the native French speakers to review and approve as well. @dduportal or @smerle33 or @lemeurherve or @gounthar
core/src/main/resources/hudson/util/HudsonIsRestarting/index_fr.properties
Outdated
Show resolved
Hide resolved
@gounthar I changed ^^. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion, LGTM otherwise.
Please\ wait\ while\ Jenkins\ is\ restarting=Veuillez attendre pendant que Jenkins redémarre | ||
Your\ browser\ will\ reload\ automatically\ when\ Jenkins\ is\ ready.=Votre navigateur se connectera automatiquement quand Jenkins sera prêt | ||
Your\ browser\ will\ reload\ automatically\ when\ Jenkins\ is\ ready.=Votre navigateur se connectera automatiquement quand Jenkins sera prêt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your\ browser\ will\ reload\ automatically\ when\ Jenkins\ is\ ready.=Votre navigateur se connectera automatiquement quand Jenkins sera prêt. | |
Your\ browser\ will\ reload\ automatically\ when\ Jenkins\ is\ ready.=Votre navigateur se rafraîchira automatiquement quand Jenkins sera prêt. |
@hervelemeur I applied your suggestion ^^. |
core/src/main/resources/hudson/util/HudsonIsRestarting/index_fr.properties
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/label ready-to-merge This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. |
I wasn't able to add the following labels: ready-to-merge Check that the label exists and is spelt right then try again. |
I've labeled it as Thanks again for the contribution! |
No that's fine. You can keep this excluded from the changelog ^^. |
All is in the title ^^.
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist