[JENKINS-64816] prepare for support of node monitors by JCasC #8629

mawinter69 · 2023-10-21T20:35:33Z

In order that configuration as code plugin can properly support node monitors we need to add databound constructors.

Testing done

No functional changes, verified in the context of jenkinsci/configuration-as-code-plugin#2392 that with this change the node monitors can then be configured via CasC

Proposed changelog entries

Prepare node monitors to work with configuration as code.

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

In order that configuration as code plugin can properly support node monitors we need to add databound constructors.

requires jenkinsci/jenkins#8629

daniel-beck

Looks like we might be able to get rid of a few #newInstance as well, but reasonable to consider that out of scope.

core/src/main/java/hudson/node_monitors/DiskSpaceMonitor.java

daniel-beck · 2023-10-26T11:52:05Z

core/src/main/java/hudson/node_monitors/DiskSpaceMonitor.java

+    public static /*almost final*/ DiskSpaceMonitorDescriptor DESCRIPTOR;
+
+    @Extension @Symbol("diskSpace")
+    public static class DescriptorImpl extends DiskSpaceMonitorDescriptor {


Unsure whether we want @since for this. Technically, yes?

I don't really see the need for this here.

daniel-beck · 2023-10-26T11:52:24Z

core/src/main/java/hudson/node_monitors/ResponseTimeMonitor.java

    @Extension
-    public static final AbstractNodeMonitorDescriptor<Data> DESCRIPTOR = new AbstractAsyncNodeMonitorDescriptor<>() {
+    @Symbol("responseTime")
+    public static class DescriptorImpl extends AbstractAsyncNodeMonitorDescriptor<Data> {


Unsure whether we want @since for this. Technically, yes?

NotMyFault

nice

NotMyFault · 2023-11-13T19:23:24Z

Hey @mawinter69,

would you mind addressing or commenting on the outstanding concerns, please?

daniel-beck · 2023-11-13T22:11:31Z

Noting that comments have been addressed by declining.

NotMyFault · 2023-11-16T21:51:20Z

/label ready-for-merge

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

[JENKINS-64816] prepare for support of node monitors by JCasC

212436f

In order that configuration as code plugin can properly support node monitors we need to add databound constructors.

mawinter69 added a commit to mawinter69/configuration-as-code-plugin that referenced this pull request Oct 21, 2023

[JENKINS-64816] support for node monitors in CasC

827e984

requires jenkinsci/jenkins#8629

mawinter69 mentioned this pull request Oct 21, 2023

[JENKINS-64816] support for node monitors in CasC jenkinsci/configuration-as-code-plugin#2392

Merged

6 tasks

fix warnings

ebab8bd

mawinter69 force-pushed the JENKINS-64816 branch from 3997d7b to ebab8bd Compare October 23, 2023 16:01

add javadoc that DataBoundConstructor is a must

e73df31

daniel-beck reviewed Oct 25, 2023

View reviewed changes

core/src/main/java/hudson/node_monitors/DiskSpaceMonitor.java Show resolved Hide resolved

remove duplicate extension

fcfacfd

daniel-beck reviewed Oct 25, 2023

View reviewed changes

core/src/main/java/hudson/node_monitors/DiskSpaceMonitor.java Outdated Show resolved Hide resolved

delete obsolete install methods

667deda

daniel-beck approved these changes Oct 26, 2023

View reviewed changes

NotMyFault added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Oct 29, 2023

NotMyFault approved these changes Oct 31, 2023

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 16, 2023

MarkEWaite merged commit 442a42f into jenkinsci:master Nov 18, 2023

mawinter69 deleted the JENKINS-64816 branch January 31, 2025 13:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-64816] prepare for support of node monitors by JCasC #8629

[JENKINS-64816] prepare for support of node monitors by JCasC #8629

mawinter69 commented Oct 21, 2023 •

edited by MarkEWaite

Loading

Submitter checklist

Maintainer checklist

daniel-beck left a comment

daniel-beck Oct 26, 2023

mawinter69 Nov 13, 2023 •

edited

Loading

daniel-beck Oct 26, 2023

mawinter69 Nov 13, 2023

NotMyFault left a comment

NotMyFault commented Nov 13, 2023

daniel-beck commented Nov 13, 2023

NotMyFault commented Nov 16, 2023

[JENKINS-64816] prepare for support of node monitors by JCasC #8629

[JENKINS-64816] prepare for support of node monitors by JCasC #8629

Conversation

mawinter69 commented Oct 21, 2023 • edited by MarkEWaite Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

daniel-beck left a comment

Choose a reason for hiding this comment

daniel-beck Oct 26, 2023

Choose a reason for hiding this comment

mawinter69 Nov 13, 2023 • edited Loading

Choose a reason for hiding this comment

daniel-beck Oct 26, 2023

Choose a reason for hiding this comment

mawinter69 Nov 13, 2023

Choose a reason for hiding this comment

NotMyFault left a comment

Choose a reason for hiding this comment

NotMyFault commented Nov 13, 2023

daniel-beck commented Nov 13, 2023

NotMyFault commented Nov 16, 2023

mawinter69 commented Oct 21, 2023 •

edited by MarkEWaite

Loading

mawinter69 Nov 13, 2023 •

edited

Loading