Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72181] Restore flushed output for 'groovy' CLI command #8622

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Oct 18, 2023

See JENKINS-72181. Amends #7056.

I accidentally wrapped the PrintWriter in the logging ScriptListener.ListenerWriter that only implements the basic #write(…) and doesn't automatically flush. This switches the order around, so the autoflush in PrintWriter#newLine happens as before.

Testing done

$ echo 'println "Hello"'  | java -jar jenkins-cli.jar -s http://localhost:8080/jenkins/ groovy =
Hello

The added test passes with change in core/src/main/ and fails without.

Proposed changelog entries

  • Restore printing output from println and similar methods for the 'groovy' CLI command. (regression in 2.427)

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@daniel-beck daniel-beck added regression-fix Pull request that fixes a regression in one of the previous Jenkins releases bug For changelog: Minor bug. Will be listed after features labels Oct 18, 2023
@daniel-beck daniel-beck marked this pull request as ready for review October 19, 2023 07:21
@basil basil self-assigned this Oct 19, 2023
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 19, 2023
@basil basil merged commit 8f5167d into jenkinsci:master Oct 20, 2023
16 checks passed
@NotMyFault NotMyFault removed the bug For changelog: Minor bug. Will be listed after features label Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants